Skip to content

tests/ui: A New Order [9/N] #142214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

tests/ui: A New Order [9/N] #142214

wants to merge 8 commits into from
+85 −74

Conversation

Kivooeo
Copy link
Contributor

@Kivooeo Kivooeo commented Jun 8, 2025

Note

Intermediate commits are intended to help review, but will be squashed prior to merge.

Some tests/ui/ housekeeping, to trim down number of tests directly under tests/ui/. Part of #133895.

@rustbot
Copy link
Collaborator

rustbot commented Jun 8, 2025

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 8, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Kivooeo Kivooeo mentioned this pull request Jun 11, 2025
Merged
@jieyouxu
Copy link
Member

r? jieyouxu

@rustbot rustbot assigned jieyouxu and unassigned davidtwco Jun 11, 2025
jieyouxu
jieyouxu requested changes Jun 28, 2025
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, one nit, please squash after and I'll r+

tests/ui/allocator/empty-alloc-nonnull-guarantee.rs
Comment on lines +3 to +5
//! This test ensures that Rust's allocator maintains the invariant that
//! Box<T> is always non-null, even for zero-sized types and empty allocations.
//! This is crucial for memory safety guarantees in Rust.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: this guarantee is overly strong for what this test actually does, it's more like

Check that the default global Rust allocator in combination with Box produces a non-null allocation even when the contained type is zero-sized.

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jieyouxu jieyouxu jieyouxu requested changes

Assignees

@jieyouxu jieyouxu

Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Kivooeo @rustbot @rust-log-analyzer @jieyouxu @davidtwco